Python Scraping Images With BeautifulSoup












1














I'm trying to scrape and download images from a website using BeautifulSoup. I have scraped a list of links stored in imgVal, the code can then create a new directory to store the images. The problem I have is the code will only download one image from the list of links. I would like to download them all. How can I accomplish this?



from bs4 import BeautifulSoup
from os.path import basename
import requests
import os

...

def writeImages():
imgVal = getThumbnailLinks()
imgBasename = 'n'.join(map(str, imgVal))

pageNumber = '001'
filename = pageNumber + '/'
os.makedirs(os.path.dirname(filename), exist_ok=True)

with open(filename + basename(imgBasename),"wb") as f:
f.write(requests.get(imgBasename).content)

writeImages()









share|improve this question






















  • Do you store in imgVal array (dictionary) of links? Or just single one? Could you show implementation of getThumbnailLinks() function? Because if it is collection of links, as you've written, I'm not sure that imgBasename = 'n'.join(map(str, imgVal)) will work...
    – kosist
    Nov 21 '18 at 14:17
















1














I'm trying to scrape and download images from a website using BeautifulSoup. I have scraped a list of links stored in imgVal, the code can then create a new directory to store the images. The problem I have is the code will only download one image from the list of links. I would like to download them all. How can I accomplish this?



from bs4 import BeautifulSoup
from os.path import basename
import requests
import os

...

def writeImages():
imgVal = getThumbnailLinks()
imgBasename = 'n'.join(map(str, imgVal))

pageNumber = '001'
filename = pageNumber + '/'
os.makedirs(os.path.dirname(filename), exist_ok=True)

with open(filename + basename(imgBasename),"wb") as f:
f.write(requests.get(imgBasename).content)

writeImages()









share|improve this question






















  • Do you store in imgVal array (dictionary) of links? Or just single one? Could you show implementation of getThumbnailLinks() function? Because if it is collection of links, as you've written, I'm not sure that imgBasename = 'n'.join(map(str, imgVal)) will work...
    – kosist
    Nov 21 '18 at 14:17














1












1








1







I'm trying to scrape and download images from a website using BeautifulSoup. I have scraped a list of links stored in imgVal, the code can then create a new directory to store the images. The problem I have is the code will only download one image from the list of links. I would like to download them all. How can I accomplish this?



from bs4 import BeautifulSoup
from os.path import basename
import requests
import os

...

def writeImages():
imgVal = getThumbnailLinks()
imgBasename = 'n'.join(map(str, imgVal))

pageNumber = '001'
filename = pageNumber + '/'
os.makedirs(os.path.dirname(filename), exist_ok=True)

with open(filename + basename(imgBasename),"wb") as f:
f.write(requests.get(imgBasename).content)

writeImages()









share|improve this question













I'm trying to scrape and download images from a website using BeautifulSoup. I have scraped a list of links stored in imgVal, the code can then create a new directory to store the images. The problem I have is the code will only download one image from the list of links. I would like to download them all. How can I accomplish this?



from bs4 import BeautifulSoup
from os.path import basename
import requests
import os

...

def writeImages():
imgVal = getThumbnailLinks()
imgBasename = 'n'.join(map(str, imgVal))

pageNumber = '001'
filename = pageNumber + '/'
os.makedirs(os.path.dirname(filename), exist_ok=True)

with open(filename + basename(imgBasename),"wb") as f:
f.write(requests.get(imgBasename).content)

writeImages()






python beautifulsoup with-statement






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 21 '18 at 13:59









Max SebastianMax Sebastian

104




104












  • Do you store in imgVal array (dictionary) of links? Or just single one? Could you show implementation of getThumbnailLinks() function? Because if it is collection of links, as you've written, I'm not sure that imgBasename = 'n'.join(map(str, imgVal)) will work...
    – kosist
    Nov 21 '18 at 14:17


















  • Do you store in imgVal array (dictionary) of links? Or just single one? Could you show implementation of getThumbnailLinks() function? Because if it is collection of links, as you've written, I'm not sure that imgBasename = 'n'.join(map(str, imgVal)) will work...
    – kosist
    Nov 21 '18 at 14:17
















Do you store in imgVal array (dictionary) of links? Or just single one? Could you show implementation of getThumbnailLinks() function? Because if it is collection of links, as you've written, I'm not sure that imgBasename = 'n'.join(map(str, imgVal)) will work...
– kosist
Nov 21 '18 at 14:17




Do you store in imgVal array (dictionary) of links? Or just single one? Could you show implementation of getThumbnailLinks() function? Because if it is collection of links, as you've written, I'm not sure that imgBasename = 'n'.join(map(str, imgVal)) will work...
– kosist
Nov 21 '18 at 14:17












1 Answer
1






active

oldest

votes


















1














so you want to download multi line URL as input for requests? you can't, you have to do it one by one using loop.



def writeImages():
pageNumber = '001'
filename = pageNumber + '/'
os.makedirs(os.path.dirname(filename), exist_ok=True)

imgVal = getThumbnailLinks() # ['http://a.jpg', 'http://b.jpg']
for imgBasename in imgVal:
with open(filename + basename(imgBasename),"wb") as f:
f.write(requests.get(imgBasename).content)

writeImages()





share|improve this answer





















    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53413741%2fpython-scraping-images-with-beautifulsoup%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    1














    so you want to download multi line URL as input for requests? you can't, you have to do it one by one using loop.



    def writeImages():
    pageNumber = '001'
    filename = pageNumber + '/'
    os.makedirs(os.path.dirname(filename), exist_ok=True)

    imgVal = getThumbnailLinks() # ['http://a.jpg', 'http://b.jpg']
    for imgBasename in imgVal:
    with open(filename + basename(imgBasename),"wb") as f:
    f.write(requests.get(imgBasename).content)

    writeImages()





    share|improve this answer


























      1














      so you want to download multi line URL as input for requests? you can't, you have to do it one by one using loop.



      def writeImages():
      pageNumber = '001'
      filename = pageNumber + '/'
      os.makedirs(os.path.dirname(filename), exist_ok=True)

      imgVal = getThumbnailLinks() # ['http://a.jpg', 'http://b.jpg']
      for imgBasename in imgVal:
      with open(filename + basename(imgBasename),"wb") as f:
      f.write(requests.get(imgBasename).content)

      writeImages()





      share|improve this answer
























        1












        1








        1






        so you want to download multi line URL as input for requests? you can't, you have to do it one by one using loop.



        def writeImages():
        pageNumber = '001'
        filename = pageNumber + '/'
        os.makedirs(os.path.dirname(filename), exist_ok=True)

        imgVal = getThumbnailLinks() # ['http://a.jpg', 'http://b.jpg']
        for imgBasename in imgVal:
        with open(filename + basename(imgBasename),"wb") as f:
        f.write(requests.get(imgBasename).content)

        writeImages()





        share|improve this answer












        so you want to download multi line URL as input for requests? you can't, you have to do it one by one using loop.



        def writeImages():
        pageNumber = '001'
        filename = pageNumber + '/'
        os.makedirs(os.path.dirname(filename), exist_ok=True)

        imgVal = getThumbnailLinks() # ['http://a.jpg', 'http://b.jpg']
        for imgBasename in imgVal:
        with open(filename + basename(imgBasename),"wb") as f:
        f.write(requests.get(imgBasename).content)

        writeImages()






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 21 '18 at 15:26









        ewwinkewwink

        10.8k22236




        10.8k22236






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53413741%2fpython-scraping-images-with-beautifulsoup%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Tonle Sap (See)

            I get strange results when I access the Sqlitedatabase with Unity C# via XAMPP

            Guatemaltekische Davis-Cup-Mannschaft