Problem to implement an insertion algorithms












0















I write such a insertion algorithms:



In [33]: %paste                                                                                                  
def insertion_sort2(arr):
for i in range(1, len(arr)):
insert_item = arr[i]
for j in range(i):#insert to sorted array arr[:i]
if insert_item < arr[j]:
arr[j] = insert_item


Test it



In [35]: arr                                                                                                     
Out[35]: [0, 0, 0, 2, 3, 3, 6, 6, 6]
In [36]: arr = list(range(9))
In [37]: random.shuffle(arr)
In [38]: insertion_sort2(arr)
In [39]: arr
Out[39]: [0, 0, 0, 0, 0, 0, 3, 3, 3]


I check the logic but cannot find any problem.



1. i in arr[1:len]
2. insert arr[i] to arr[:i]


What' the problem with my implementation?










share|improve this question



























    0















    I write such a insertion algorithms:



    In [33]: %paste                                                                                                  
    def insertion_sort2(arr):
    for i in range(1, len(arr)):
    insert_item = arr[i]
    for j in range(i):#insert to sorted array arr[:i]
    if insert_item < arr[j]:
    arr[j] = insert_item


    Test it



    In [35]: arr                                                                                                     
    Out[35]: [0, 0, 0, 2, 3, 3, 6, 6, 6]
    In [36]: arr = list(range(9))
    In [37]: random.shuffle(arr)
    In [38]: insertion_sort2(arr)
    In [39]: arr
    Out[39]: [0, 0, 0, 0, 0, 0, 3, 3, 3]


    I check the logic but cannot find any problem.



    1. i in arr[1:len]
    2. insert arr[i] to arr[:i]


    What' the problem with my implementation?










    share|improve this question

























      0












      0








      0








      I write such a insertion algorithms:



      In [33]: %paste                                                                                                  
      def insertion_sort2(arr):
      for i in range(1, len(arr)):
      insert_item = arr[i]
      for j in range(i):#insert to sorted array arr[:i]
      if insert_item < arr[j]:
      arr[j] = insert_item


      Test it



      In [35]: arr                                                                                                     
      Out[35]: [0, 0, 0, 2, 3, 3, 6, 6, 6]
      In [36]: arr = list(range(9))
      In [37]: random.shuffle(arr)
      In [38]: insertion_sort2(arr)
      In [39]: arr
      Out[39]: [0, 0, 0, 0, 0, 0, 3, 3, 3]


      I check the logic but cannot find any problem.



      1. i in arr[1:len]
      2. insert arr[i] to arr[:i]


      What' the problem with my implementation?










      share|improve this question














      I write such a insertion algorithms:



      In [33]: %paste                                                                                                  
      def insertion_sort2(arr):
      for i in range(1, len(arr)):
      insert_item = arr[i]
      for j in range(i):#insert to sorted array arr[:i]
      if insert_item < arr[j]:
      arr[j] = insert_item


      Test it



      In [35]: arr                                                                                                     
      Out[35]: [0, 0, 0, 2, 3, 3, 6, 6, 6]
      In [36]: arr = list(range(9))
      In [37]: random.shuffle(arr)
      In [38]: insertion_sort2(arr)
      In [39]: arr
      Out[39]: [0, 0, 0, 0, 0, 0, 3, 3, 3]


      I check the logic but cannot find any problem.



      1. i in arr[1:len]
      2. insert arr[i] to arr[:i]


      What' the problem with my implementation?







      python algorithm






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 24 '18 at 6:04









      JawSawJawSaw

      4,57811837




      4,57811837
























          1 Answer
          1






          active

          oldest

          votes


















          1














          The line



          arr[j] = insert_item


          overwrites arr[j]. It does NOT insert.



          >>> l = list(range(10))
          >>> l
          [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
          >>> l[3] = 'foo'
          >>> l
          [0, 1, 2, 'foo', 4, 5, 6, 7, 8, 9]
          >>> l.insert(7, 'bar')
          >>> l
          [0, 1, 2, 'foo', 4, 5, 6, 'bar', 7, 8, 9]





          share|improve this answer























            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53455608%2fproblem-to-implement-an-insertion-algorithms%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            1














            The line



            arr[j] = insert_item


            overwrites arr[j]. It does NOT insert.



            >>> l = list(range(10))
            >>> l
            [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
            >>> l[3] = 'foo'
            >>> l
            [0, 1, 2, 'foo', 4, 5, 6, 7, 8, 9]
            >>> l.insert(7, 'bar')
            >>> l
            [0, 1, 2, 'foo', 4, 5, 6, 'bar', 7, 8, 9]





            share|improve this answer




























              1














              The line



              arr[j] = insert_item


              overwrites arr[j]. It does NOT insert.



              >>> l = list(range(10))
              >>> l
              [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
              >>> l[3] = 'foo'
              >>> l
              [0, 1, 2, 'foo', 4, 5, 6, 7, 8, 9]
              >>> l.insert(7, 'bar')
              >>> l
              [0, 1, 2, 'foo', 4, 5, 6, 'bar', 7, 8, 9]





              share|improve this answer


























                1












                1








                1







                The line



                arr[j] = insert_item


                overwrites arr[j]. It does NOT insert.



                >>> l = list(range(10))
                >>> l
                [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
                >>> l[3] = 'foo'
                >>> l
                [0, 1, 2, 'foo', 4, 5, 6, 7, 8, 9]
                >>> l.insert(7, 'bar')
                >>> l
                [0, 1, 2, 'foo', 4, 5, 6, 'bar', 7, 8, 9]





                share|improve this answer













                The line



                arr[j] = insert_item


                overwrites arr[j]. It does NOT insert.



                >>> l = list(range(10))
                >>> l
                [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
                >>> l[3] = 'foo'
                >>> l
                [0, 1, 2, 'foo', 4, 5, 6, 7, 8, 9]
                >>> l.insert(7, 'bar')
                >>> l
                [0, 1, 2, 'foo', 4, 5, 6, 'bar', 7, 8, 9]






                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 24 '18 at 6:10









                Martin ThomaMartin Thoma

                42.9k60304525




                42.9k60304525
































                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53455608%2fproblem-to-implement-an-insertion-algorithms%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Wiesbaden

                    Marschland

                    Dieringhausen