setting state twice in a geocodeByAddress function
0
I am trying to set state to the trip object based on the return of the geocodeByAddress react-places-autocomplete function. The return of the latitude and the longitude gets mapped to pickup object and the latitude/longtitude params. However, the setState twice does not work. Can anyone see a work-around?
class App extends Component {
constructor(props) {
super(props);
this.state = {
trip: {
pickUp: null,
},
pickupLatitudeDisplay: '',
pickupLongitudeDisplay: '',
}
}
handlePickupSelect = address => {
const {
pickupLatitudeDisplay,
pickupLongitudeDisplay,
} = this.state;
geocodeByAddress(address)
.then(results => getLatLng(results[0]))
.then(results => {
console.log('Success', results)
this.setState({
pickupLatitudeDisplay: results.lat,
pickupLongitudeDisplay: results.lng,
}, () => {
this.setState({
trip: {
...this.state.trip,
pickUp: {
...this.state.trip.pickUp,
latitude: pickupLatitudeDisplay,
longitude: pickupLongitudeDisplay,
},
}
})
})
})
.catch(error => console.error('Error', error));}
javascript reactjs
asked Nov 22 '18 at 17:00
kseniaksenia
638
add a comment |
0
I am trying to set state to the trip object based on the return of the geocodeByAddress react-places-autocomplete function. The return of the latitude and the longitude gets mapped to pickup object and the latitude/longtitude params. However, the setState twice does not work. Can anyone see a work-around?
class App extends Component {
constructor(props) {
super(props);
this.state = {
trip: {
pickUp: null,
},
pickupLatitudeDisplay: '',
pickupLongitudeDisplay: '',
}
}
handlePickupSelect = address => {
const {
pickupLatitudeDisplay,
pickupLongitudeDisplay,
} = this.state;
geocodeByAddress(address)
.then(results => getLatLng(results[0]))
.then(results => {
console.log('Success', results)
this.setState({
pickupLatitudeDisplay: results.lat,
pickupLongitudeDisplay: results.lng,
}, () => {
this.setState({
trip: {
...this.state.trip,
pickUp: {
...this.state.trip.pickUp,
latitude: pickupLatitudeDisplay,
longitude: pickupLongitudeDisplay,
},
}
})
})
})
.catch(error => console.error('Error', error));}
javascript reactjs
asked Nov 22 '18 at 17:00
kseniaksenia
638
setStateis async method, component should reactive "react" at changes. What you experienced here are so called "side effects". For async methods you should try something like redux-thunk or redux-observable. But at first move state to props, if you don't want to change it to props, you have to "observe" (eg. using rxjs observable) for state changes.
– Zydnar
Nov 22 '18 at 17:08
3
What's not working? Guess you're getting an error when you try to spread this.state.trip.pickUp cause it's null in the initial state. Set it to an empty object initially instead. Also don't follow along quite here as we can't see more of the code. But why are you setting the state two times? You could set it all in one setState call as far as I can see it.
– weibenfalk
Nov 22 '18 at 17:10
add a comment |
0
0
0
I am trying to set state to the trip object based on the return of the geocodeByAddress react-places-autocomplete function. The return of the latitude and the longitude gets mapped to pickup object and the latitude/longtitude params. However, the setState twice does not work. Can anyone see a work-around?
class App extends Component {
constructor(props) {
super(props);
this.state = {
trip: {
pickUp: null,
},
pickupLatitudeDisplay: '',
pickupLongitudeDisplay: '',
}
}
handlePickupSelect = address => {
const {
pickupLatitudeDisplay,
pickupLongitudeDisplay,
} = this.state;
geocodeByAddress(address)
.then(results => getLatLng(results[0]))
.then(results => {
console.log('Success', results)
this.setState({
pickupLatitudeDisplay: results.lat,
pickupLongitudeDisplay: results.lng,
}, () => {
this.setState({
trip: {
...this.state.trip,
pickUp: {
...this.state.trip.pickUp,
latitude: pickupLatitudeDisplay,
longitude: pickupLongitudeDisplay,
},
}
})
})
})
.catch(error => console.error('Error', error));}
javascript reactjs
asked Nov 22 '18 at 17:00
kseniaksenia
638
I am trying to set state to the trip object based on the return of the geocodeByAddress react-places-autocomplete function. The return of the latitude and the longitude gets mapped to pickup object and the latitude/longtitude params. However, the setState twice does not work. Can anyone see a work-around?
class App extends Component {
constructor(props) {
super(props);
this.state = {
trip: {
pickUp: null,
},
pickupLatitudeDisplay: '',
pickupLongitudeDisplay: '',
}
}
handlePickupSelect = address => {
const {
pickupLatitudeDisplay,
pickupLongitudeDisplay,
} = this.state;
geocodeByAddress(address)
.then(results => getLatLng(results[0]))
.then(results => {
console.log('Success', results)
this.setState({
pickupLatitudeDisplay: results.lat,
pickupLongitudeDisplay: results.lng,
}, () => {
this.setState({
trip: {
...this.state.trip,
pickUp: {
...this.state.trip.pickUp,
latitude: pickupLatitudeDisplay,
longitude: pickupLongitudeDisplay,
},
}
})
})
})
.catch(error => console.error('Error', error));}
javascript reactjs
javascript reactjs
asked Nov 22 '18 at 17:00
kseniaksenia
638
asked Nov 22 '18 at 17:00
kseniaksenia
638
asked Nov 22 '18 at 17:00
kseniaksenia
638
asked Nov 22 '18 at 17:00
kseniaksenia
638
asked Nov 22 '18 at 17:00
kseniaksenia
638
638
setStateis async method, component should reactive "react" at changes. What you experienced here are so called "side effects". For async methods you should try something like redux-thunk or redux-observable. But at first move state to props, if you don't want to change it to props, you have to "observe" (eg. using rxjs observable) for state changes.
– Zydnar
Nov 22 '18 at 17:08
3
What's not working? Guess you're getting an error when you try to spread this.state.trip.pickUp cause it's null in the initial state. Set it to an empty object initially instead. Also don't follow along quite here as we can't see more of the code. But why are you setting the state two times? You could set it all in one setState call as far as I can see it.
– weibenfalk
Nov 22 '18 at 17:10
add a comment |
setStateis async method, component should reactive "react" at changes. What you experienced here are so called "side effects". For async methods you should try something like redux-thunk or redux-observable. But at first move state to props, if you don't want to change it to props, you have to "observe" (eg. using rxjs observable) for state changes.
– Zydnar
Nov 22 '18 at 17:08
3
What's not working? Guess you're getting an error when you try to spread this.state.trip.pickUp cause it's null in the initial state. Set it to an empty object initially instead. Also don't follow along quite here as we can't see more of the code. But why are you setting the state two times? You could set it all in one setState call as far as I can see it.
– weibenfalk
Nov 22 '18 at 17:10
setState is async method, component should reactive "react" at changes. What you experienced here are so called "side effects". For async methods you should try something like redux-thunk or redux-observable. But at first move state to props, if you don't want to change it to props, you have to "observe" (eg. using rxjs observable) for state changes.– Zydnar
Nov 22 '18 at 17:08
setState is async method, component should reactive "react" at changes. What you experienced here are so called "side effects". For async methods you should try something like redux-thunk or redux-observable. But at first move state to props, if you don't want to change it to props, you have to "observe" (eg. using rxjs observable) for state changes.– Zydnar
Nov 22 '18 at 17:08
3
3
What's not working? Guess you're getting an error when you try to spread this.state.trip.pickUp cause it's null in the initial state. Set it to an empty object initially instead. Also don't follow along quite here as we can't see more of the code. But why are you setting the state two times? You could set it all in one setState call as far as I can see it.
– weibenfalk
Nov 22 '18 at 17:10
What's not working? Guess you're getting an error when you try to spread this.state.trip.pickUp cause it's null in the initial state. Set it to an empty object initially instead. Also don't follow along quite here as we can't see more of the code. But why are you setting the state two times? You could set it all in one setState call as far as I can see it.
– weibenfalk
Nov 22 '18 at 17:10
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53435498%2fsetting-state-twice-in-a-geocodebyaddress-function%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53435498%2fsetting-state-twice-in-a-geocodebyaddress-function%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
setStateis async method, component should reactive "react" at changes. What you experienced here are so called "side effects". For async methods you should try something like redux-thunk or redux-observable. But at first move state to props, if you don't want to change it to props, you have to "observe" (eg. using rxjs observable) for state changes.– Zydnar
Nov 22 '18 at 17:08
3
What's not working? Guess you're getting an error when you try to spread this.state.trip.pickUp cause it's null in the initial state. Set it to an empty object initially instead. Also don't follow along quite here as we can't see more of the code. But why are you setting the state two times? You could set it all in one setState call as far as I can see it.
– weibenfalk
Nov 22 '18 at 17:10