Ytukyg

I have a python script that detects a keyword from a keyword list keywords = ['camera', 'nikon'] and then sends a message to Slack like the following

Keyword camera detected

'Reddit post url'

'reddit comment that contains the keyword'

If the script detects a keyword from a second keyword list color_keywords = ['red', 'blue'] then it posts the following

Keyword camera detected

'Reddit post url'

'reddit comment that contains the keyword'

Color was detected

My question is, am I somehow able to have the script so it ONLY sends a message if a keyword from EACH keyword list is found?
So if it only finds a keyword from the first list, it will be ignored, if it finds one from the second list, it will also be ignored. but if it finds a keyword from BOTH lists, it will send the message to slack.

Below is my current code

MSG_TEMPLATE = """Keyword *{keyword}* detected

https://www.reddit.com{permalink}

```{comment_body}```"""



keywords = ['camera', 'nikon', 'canon']  

color_keywords = ['blue', 'red']



with open(save_path, 'r') as fp:

    alerted_comments = json.load(fp)



    for comment in comment_stream:

        if comment.id in alerted_comments:

            continue



        if comment.author:  # if comment author hasn't deleted

            if comment.author.name in ignore_users:

                continue



        if any(kw.lower() in comment.body.lower() for kw in keywords):

            found_kws = [kw for kw in keywords if kw.lower() in comment.body.lower()]



            msg = MSG_TEMPLATE.format(

                keyword=found_kws[0],

                permalink=comment.permalink,

                comment_body=comment.body

            )



            if any(kw.lower() in comment.body.lower() for kw in color_keywords):

                msg += "n<!here> *A color was detected*"



            slack_data = {'text': msg, 'mrkdwn': True,}



            response = requests.post('https://hooks.slack.com/services/TB7AH6U2G/xxxxxxx/0KOjl9251TZExxxxxxxx',

                                             data=json.dumps(slack_data), headers={'Content-Type': 'application/json'})

Any help will be greatly appreciated!

Sure! The code below is excerpted for brevity:

def find_keywords(comment, word_list):

    """:returns: List of matching keywords present in the comment, or the empty list"""

    return [word for word in word_list if word.lower() in comment.body.lower()]



for comment in comment_stream:

    if not should_be_ignored(comment):

        found_kws = find_keywords(comment, keywords)

        found_colors = find_keywords(comment, color_keywords)



        if found_kws and found_colors:

            # At this point, we're guaranteed to have *both* one or more keywords *and* one or more colors

            send_message(comment, found_kws, found_colors)

The key insight here is: you create your lists of matches first, and then afterward examine them to decide if you want to send a message. In this case, only if both lists are not empty will you progress to sending the message.

(Implementation of should_be_ignored() and send_message() are, of course, left as an exercise to the reader. :) )

EDIT: Complete implementation of the original code:

def send_message(comment, keywords, colors):

    assert keywords and colors, "At this point, we should *only* be calling this function if we have at least one keyword and one color"



    MSG_TEMPLATE = """Keyword *{keyword}* and color *{color}* detected

    https://www.reddit.com{permalink}

    ```{comment_body}```"""

    msg = MSG_TEMPLATE.format(

        keyword=keywords[0],

        color=colors[0],

        permalink=comment.permalink,

        comment_body=comment.body

    )

    slack_data = {'text': msg, 'mrkdwn': True,}

    response = requests.post('https://hooks.slack.com/services/TB7AH6U2G/xxxxxxx/0KOjl9251TZExxxxxxxx',

                             data=json.dumps(slack_data), headers={'Content-Type': 'application/json'})





def should_be_ignored(comment, alerted):

    return comment.id in alerted or (comment.author and comment.author.name in ignore_users)





def find_keywords(comment, word_list):

    """:returns: List of matching keywords present in the comment, or the empty list"""

    return [word for word in word_list if word.lower() in comment.body.lower()]





keywords = ['camera', 'nikon', 'canon']  

color_keywords = ['blue', 'red']



with open(save_path, 'r') as fp:

    alerted_comments = json.load(fp)



for comment in comment_stream:

    if not should_be_ignored(comment, alerted_comments):

        found_kws = find_keywords(comment, keywords)

        found_colors = find_keywords(comment, color_keywords)



        if found_kws and found_colors:

            # At this point, we're guaranteed to have *both* one or more keywords *and* one or more colors

            send_message(comment, found_kws, found_colors)

Note that all I've done (aside from the new requirement that we have both a color and a keyword before sending a message) is to pull out some of your business logic into the should_be_ignored() and send_message() functions, hopefully clarifying the intent of the main body of code. This should be a drop-in replacement for the sample you started with.