Spring Batch: SingleItemPeekableItemReader not working some times
.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty{ height:90px;width:728px;box-sizing:border-box;
}
I am trying to use SingleItemPeekableItemReader to read multiline data. This sometimes did not work and there is no error thrown. While debugging it just shows reader.peek() is null. What am i missing here?
Xml File snippet:
< bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step">
...
< /bean>
< bean id="itemReaderB" class="org.springframework.batch.item.support.SingleItemPeekableItemReader" scope="step">
< property name="delegate" ref="itemReaderA"/>
< /bean>
< bean id="TransactionFileReader" class="<customReader class>" scope="step">
< property name="delegate" ref="itemReaderB"/>
< /bean>
Read method/Class
public class customReader implements ItemReader<ELCTransactionHeader>, ItemStream {
SingleItemPeekableItemReader<ElcHKTransactionFileDatabean> delegate;
public CustomBEan read() throws Exception, ParseException, NonTransientResourceException {
InputBEan line = null;
InputBEan prevElement = null;
boolean exit = false;
CustomBEan transactionObj = null;
while (!exit && (line = (InputBEan) this.delegate.peek()) != null) {
if ((prevElement == null ) || (prevElement != null && line.getInvoiceNumber().equals(prevElement.getInvoiceNumber()))) {
System.out.println("Part of same txn or beginning of new txn");
delegate.read();
transactionObj = processLine(transactionObj , line);
prevElement = line;
} else {
System.out.println("Different txn");
exit = true;
}
}
return transactionObj;
}
spring-batch
add a comment |
I am trying to use SingleItemPeekableItemReader to read multiline data. This sometimes did not work and there is no error thrown. While debugging it just shows reader.peek() is null. What am i missing here?
Xml File snippet:
< bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step">
...
< /bean>
< bean id="itemReaderB" class="org.springframework.batch.item.support.SingleItemPeekableItemReader" scope="step">
< property name="delegate" ref="itemReaderA"/>
< /bean>
< bean id="TransactionFileReader" class="<customReader class>" scope="step">
< property name="delegate" ref="itemReaderB"/>
< /bean>
Read method/Class
public class customReader implements ItemReader<ELCTransactionHeader>, ItemStream {
SingleItemPeekableItemReader<ElcHKTransactionFileDatabean> delegate;
public CustomBEan read() throws Exception, ParseException, NonTransientResourceException {
InputBEan line = null;
InputBEan prevElement = null;
boolean exit = false;
CustomBEan transactionObj = null;
while (!exit && (line = (InputBEan) this.delegate.peek()) != null) {
if ((prevElement == null ) || (prevElement != null && line.getInvoiceNumber().equals(prevElement.getInvoiceNumber()))) {
System.out.println("Part of same txn or beginning of new txn");
delegate.read();
transactionObj = processLine(transactionObj , line);
prevElement = line;
} else {
System.out.println("Different txn");
exit = true;
}
}
return transactionObj;
}
spring-batch
not working some timesCan you isolate this behaviour to only theSingleItemPeekableItemReader? I see it used as a delegate in a custom reader.
– Mahmoud Ben Hassine
Nov 26 '18 at 13:21
Yes... I debugged this. N line which is returning null is this.delegate.peek().
– Aruna
Nov 26 '18 at 14:39
ok great, in that case can you provide a unit test that "some times" fails? I will try to help on that.
– Mahmoud Ben Hassine
Nov 26 '18 at 15:40
Sorry, I did not have time to write unit test case as of now..But for me isue is resolved with below code n configuration. Just curious whether if we call peek method first makes difference? < bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step"> ... < /bean> < bean id="TransactionFileReader" class="<customReader class>" scope="step"> < property name="delegate" ref="itemReaderA"/> < /bean>
– Aruna
Nov 29 '18 at 5:25
My Custom reader extends SingleItemPeekableItemReader and it calls read method first rather than calling peek method
– Aruna
Nov 29 '18 at 7:24
add a comment |
I am trying to use SingleItemPeekableItemReader to read multiline data. This sometimes did not work and there is no error thrown. While debugging it just shows reader.peek() is null. What am i missing here?
Xml File snippet:
< bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step">
...
< /bean>
< bean id="itemReaderB" class="org.springframework.batch.item.support.SingleItemPeekableItemReader" scope="step">
< property name="delegate" ref="itemReaderA"/>
< /bean>
< bean id="TransactionFileReader" class="<customReader class>" scope="step">
< property name="delegate" ref="itemReaderB"/>
< /bean>
Read method/Class
public class customReader implements ItemReader<ELCTransactionHeader>, ItemStream {
SingleItemPeekableItemReader<ElcHKTransactionFileDatabean> delegate;
public CustomBEan read() throws Exception, ParseException, NonTransientResourceException {
InputBEan line = null;
InputBEan prevElement = null;
boolean exit = false;
CustomBEan transactionObj = null;
while (!exit && (line = (InputBEan) this.delegate.peek()) != null) {
if ((prevElement == null ) || (prevElement != null && line.getInvoiceNumber().equals(prevElement.getInvoiceNumber()))) {
System.out.println("Part of same txn or beginning of new txn");
delegate.read();
transactionObj = processLine(transactionObj , line);
prevElement = line;
} else {
System.out.println("Different txn");
exit = true;
}
}
return transactionObj;
}
spring-batch
I am trying to use SingleItemPeekableItemReader to read multiline data. This sometimes did not work and there is no error thrown. While debugging it just shows reader.peek() is null. What am i missing here?
Xml File snippet:
< bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step">
...
< /bean>
< bean id="itemReaderB" class="org.springframework.batch.item.support.SingleItemPeekableItemReader" scope="step">
< property name="delegate" ref="itemReaderA"/>
< /bean>
< bean id="TransactionFileReader" class="<customReader class>" scope="step">
< property name="delegate" ref="itemReaderB"/>
< /bean>
Read method/Class
public class customReader implements ItemReader<ELCTransactionHeader>, ItemStream {
SingleItemPeekableItemReader<ElcHKTransactionFileDatabean> delegate;
public CustomBEan read() throws Exception, ParseException, NonTransientResourceException {
InputBEan line = null;
InputBEan prevElement = null;
boolean exit = false;
CustomBEan transactionObj = null;
while (!exit && (line = (InputBEan) this.delegate.peek()) != null) {
if ((prevElement == null ) || (prevElement != null && line.getInvoiceNumber().equals(prevElement.getInvoiceNumber()))) {
System.out.println("Part of same txn or beginning of new txn");
delegate.read();
transactionObj = processLine(transactionObj , line);
prevElement = line;
} else {
System.out.println("Different txn");
exit = true;
}
}
return transactionObj;
}
spring-batch
spring-batch
edited Nov 26 '18 at 14:44
Dmitriy Fialkovskiy
1,63751627
1,63751627
asked Nov 26 '18 at 11:16
ArunaAruna
1
1
not working some timesCan you isolate this behaviour to only theSingleItemPeekableItemReader? I see it used as a delegate in a custom reader.
– Mahmoud Ben Hassine
Nov 26 '18 at 13:21
Yes... I debugged this. N line which is returning null is this.delegate.peek().
– Aruna
Nov 26 '18 at 14:39
ok great, in that case can you provide a unit test that "some times" fails? I will try to help on that.
– Mahmoud Ben Hassine
Nov 26 '18 at 15:40
Sorry, I did not have time to write unit test case as of now..But for me isue is resolved with below code n configuration. Just curious whether if we call peek method first makes difference? < bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step"> ... < /bean> < bean id="TransactionFileReader" class="<customReader class>" scope="step"> < property name="delegate" ref="itemReaderA"/> < /bean>
– Aruna
Nov 29 '18 at 5:25
My Custom reader extends SingleItemPeekableItemReader and it calls read method first rather than calling peek method
– Aruna
Nov 29 '18 at 7:24
add a comment |
not working some timesCan you isolate this behaviour to only theSingleItemPeekableItemReader? I see it used as a delegate in a custom reader.
– Mahmoud Ben Hassine
Nov 26 '18 at 13:21
Yes... I debugged this. N line which is returning null is this.delegate.peek().
– Aruna
Nov 26 '18 at 14:39
ok great, in that case can you provide a unit test that "some times" fails? I will try to help on that.
– Mahmoud Ben Hassine
Nov 26 '18 at 15:40
Sorry, I did not have time to write unit test case as of now..But for me isue is resolved with below code n configuration. Just curious whether if we call peek method first makes difference? < bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step"> ... < /bean> < bean id="TransactionFileReader" class="<customReader class>" scope="step"> < property name="delegate" ref="itemReaderA"/> < /bean>
– Aruna
Nov 29 '18 at 5:25
My Custom reader extends SingleItemPeekableItemReader and it calls read method first rather than calling peek method
– Aruna
Nov 29 '18 at 7:24
not working some times Can you isolate this behaviour to only the SingleItemPeekableItemReader? I see it used as a delegate in a custom reader.– Mahmoud Ben Hassine
Nov 26 '18 at 13:21
not working some times Can you isolate this behaviour to only the SingleItemPeekableItemReader? I see it used as a delegate in a custom reader.– Mahmoud Ben Hassine
Nov 26 '18 at 13:21
Yes... I debugged this. N line which is returning null is this.delegate.peek().
– Aruna
Nov 26 '18 at 14:39
Yes... I debugged this. N line which is returning null is this.delegate.peek().
– Aruna
Nov 26 '18 at 14:39
ok great, in that case can you provide a unit test that "some times" fails? I will try to help on that.
– Mahmoud Ben Hassine
Nov 26 '18 at 15:40
ok great, in that case can you provide a unit test that "some times" fails? I will try to help on that.
– Mahmoud Ben Hassine
Nov 26 '18 at 15:40
Sorry, I did not have time to write unit test case as of now..But for me isue is resolved with below code n configuration. Just curious whether if we call peek method first makes difference? < bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step"> ... < /bean> < bean id="TransactionFileReader" class="<customReader class>" scope="step"> < property name="delegate" ref="itemReaderA"/> < /bean>
– Aruna
Nov 29 '18 at 5:25
Sorry, I did not have time to write unit test case as of now..But for me isue is resolved with below code n configuration. Just curious whether if we call peek method first makes difference? < bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step"> ... < /bean> < bean id="TransactionFileReader" class="<customReader class>" scope="step"> < property name="delegate" ref="itemReaderA"/> < /bean>
– Aruna
Nov 29 '18 at 5:25
My Custom reader extends SingleItemPeekableItemReader and it calls read method first rather than calling peek method
– Aruna
Nov 29 '18 at 7:24
My Custom reader extends SingleItemPeekableItemReader and it calls read method first rather than calling peek method
– Aruna
Nov 29 '18 at 7:24
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53479952%2fspring-batch-singleitempeekableitemreader-not-working-some-times%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53479952%2fspring-batch-singleitempeekableitemreader-not-working-some-times%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
not working some timesCan you isolate this behaviour to only theSingleItemPeekableItemReader? I see it used as a delegate in a custom reader.– Mahmoud Ben Hassine
Nov 26 '18 at 13:21
Yes... I debugged this. N line which is returning null is this.delegate.peek().
– Aruna
Nov 26 '18 at 14:39
ok great, in that case can you provide a unit test that "some times" fails? I will try to help on that.
– Mahmoud Ben Hassine
Nov 26 '18 at 15:40
Sorry, I did not have time to write unit test case as of now..But for me isue is resolved with below code n configuration. Just curious whether if we call peek method first makes difference? < bean id="itemReaderA" class="org.springframework.batch.item.file.FlatFileItemReader" scope="step"> ... < /bean> < bean id="TransactionFileReader" class="<customReader class>" scope="step"> < property name="delegate" ref="itemReaderA"/> < /bean>
– Aruna
Nov 29 '18 at 5:25
My Custom reader extends SingleItemPeekableItemReader and it calls read method first rather than calling peek method
– Aruna
Nov 29 '18 at 7:24