Display const in template with Angular 4 / ionic
up vote
-1
down vote
favorite
I have constants declared in the constructor in my .ts file. I'd like to display their value in the template.
Is it good practices?
EDIT:
import {Component, OnInit, Output} from '@angular/core';
import { NavController } from 'ionic-angular';
import {MemoryEditPage} from "../memory-edit/memory-edit";
@Component({
selector: 'page-memory-list',
templateUrl: 'memory-list.html',
})
export class MemoryListPage implements OnInit {
@Output() k_user: string;
@Output() type: MemoryType = MemoryType.memories;
constructor(
private auth: AuthService,
public navCtrl: NavController,
) {
const monthNames = ['Janvier','Février','Mars','Avil','Mai','Juin','Juillet','Août','Septembre','Octobre','Novembre','Décembre'];
const thisMonth = monthNames[(new Date()).getMonth()];
const dayNames = ['Lun','Mar','Mer','Jeu','Ven','Sam','Dim'];
const thisDay = dayNames[(new Date()).getDay() - 1];
const thisDate = (new Date()).getDate();
this.thisDay = thisDay;
this.thisDate = thisDate;
this.thisMonth = thisMonth;
}
}
Template:
<ion-label no-margin text-uppercase color="white">{{thisMonth}}</ion-label>
angular ionic-framework
add a comment |
up vote
-1
down vote
favorite
I have constants declared in the constructor in my .ts file. I'd like to display their value in the template.
Is it good practices?
EDIT:
import {Component, OnInit, Output} from '@angular/core';
import { NavController } from 'ionic-angular';
import {MemoryEditPage} from "../memory-edit/memory-edit";
@Component({
selector: 'page-memory-list',
templateUrl: 'memory-list.html',
})
export class MemoryListPage implements OnInit {
@Output() k_user: string;
@Output() type: MemoryType = MemoryType.memories;
constructor(
private auth: AuthService,
public navCtrl: NavController,
) {
const monthNames = ['Janvier','Février','Mars','Avil','Mai','Juin','Juillet','Août','Septembre','Octobre','Novembre','Décembre'];
const thisMonth = monthNames[(new Date()).getMonth()];
const dayNames = ['Lun','Mar','Mer','Jeu','Ven','Sam','Dim'];
const thisDay = dayNames[(new Date()).getDay() - 1];
const thisDate = (new Date()).getDate();
this.thisDay = thisDay;
this.thisDate = thisDate;
this.thisMonth = thisMonth;
}
}
Template:
<ion-label no-margin text-uppercase color="white">{{thisMonth}}</ion-label>
angular ionic-framework
Well, it won't work, so I guess we can say it's not good practice. The view doesn't have access to local variables of the constructor. They're local variables.
– JB Nizet
Nov 20 at 6:52
sorry I forgot a few lines and my code was not functional. My question is still there: is this best practices to put variables withthis.
in the constructor or should I put them elsewhere?
– Louis
Nov 20 at 7:56
The monthNames and dayNames don't need to be recreated every time the constructor is invoked. Just store them in a constant, outside of the class. The other local variables are useless. Just initialize the fields directly. Don't recreate a new Date() for each of them: create it once. And note that Angular already have ways to get month and day names.
– JB Nizet
Nov 20 at 8:03
Ok thanks for your comment. Can you point me to "Angular's ways to get month and day names." ?
– Louis
Nov 20 at 22:57
angular.io/api/common/getLocaleMonthNames, angular.io/api/common/getLocaleDayNames, angular.io/guide/i18n
– JB Nizet
Nov 20 at 23:03
add a comment |
up vote
-1
down vote
favorite
up vote
-1
down vote
favorite
I have constants declared in the constructor in my .ts file. I'd like to display their value in the template.
Is it good practices?
EDIT:
import {Component, OnInit, Output} from '@angular/core';
import { NavController } from 'ionic-angular';
import {MemoryEditPage} from "../memory-edit/memory-edit";
@Component({
selector: 'page-memory-list',
templateUrl: 'memory-list.html',
})
export class MemoryListPage implements OnInit {
@Output() k_user: string;
@Output() type: MemoryType = MemoryType.memories;
constructor(
private auth: AuthService,
public navCtrl: NavController,
) {
const monthNames = ['Janvier','Février','Mars','Avil','Mai','Juin','Juillet','Août','Septembre','Octobre','Novembre','Décembre'];
const thisMonth = monthNames[(new Date()).getMonth()];
const dayNames = ['Lun','Mar','Mer','Jeu','Ven','Sam','Dim'];
const thisDay = dayNames[(new Date()).getDay() - 1];
const thisDate = (new Date()).getDate();
this.thisDay = thisDay;
this.thisDate = thisDate;
this.thisMonth = thisMonth;
}
}
Template:
<ion-label no-margin text-uppercase color="white">{{thisMonth}}</ion-label>
angular ionic-framework
I have constants declared in the constructor in my .ts file. I'd like to display their value in the template.
Is it good practices?
EDIT:
import {Component, OnInit, Output} from '@angular/core';
import { NavController } from 'ionic-angular';
import {MemoryEditPage} from "../memory-edit/memory-edit";
@Component({
selector: 'page-memory-list',
templateUrl: 'memory-list.html',
})
export class MemoryListPage implements OnInit {
@Output() k_user: string;
@Output() type: MemoryType = MemoryType.memories;
constructor(
private auth: AuthService,
public navCtrl: NavController,
) {
const monthNames = ['Janvier','Février','Mars','Avil','Mai','Juin','Juillet','Août','Septembre','Octobre','Novembre','Décembre'];
const thisMonth = monthNames[(new Date()).getMonth()];
const dayNames = ['Lun','Mar','Mer','Jeu','Ven','Sam','Dim'];
const thisDay = dayNames[(new Date()).getDay() - 1];
const thisDate = (new Date()).getDate();
this.thisDay = thisDay;
this.thisDate = thisDate;
this.thisMonth = thisMonth;
}
}
Template:
<ion-label no-margin text-uppercase color="white">{{thisMonth}}</ion-label>
angular ionic-framework
angular ionic-framework
edited Nov 20 at 7:55
asked Nov 20 at 6:49
Louis
1,21483273
1,21483273
Well, it won't work, so I guess we can say it's not good practice. The view doesn't have access to local variables of the constructor. They're local variables.
– JB Nizet
Nov 20 at 6:52
sorry I forgot a few lines and my code was not functional. My question is still there: is this best practices to put variables withthis.
in the constructor or should I put them elsewhere?
– Louis
Nov 20 at 7:56
The monthNames and dayNames don't need to be recreated every time the constructor is invoked. Just store them in a constant, outside of the class. The other local variables are useless. Just initialize the fields directly. Don't recreate a new Date() for each of them: create it once. And note that Angular already have ways to get month and day names.
– JB Nizet
Nov 20 at 8:03
Ok thanks for your comment. Can you point me to "Angular's ways to get month and day names." ?
– Louis
Nov 20 at 22:57
angular.io/api/common/getLocaleMonthNames, angular.io/api/common/getLocaleDayNames, angular.io/guide/i18n
– JB Nizet
Nov 20 at 23:03
add a comment |
Well, it won't work, so I guess we can say it's not good practice. The view doesn't have access to local variables of the constructor. They're local variables.
– JB Nizet
Nov 20 at 6:52
sorry I forgot a few lines and my code was not functional. My question is still there: is this best practices to put variables withthis.
in the constructor or should I put them elsewhere?
– Louis
Nov 20 at 7:56
The monthNames and dayNames don't need to be recreated every time the constructor is invoked. Just store them in a constant, outside of the class. The other local variables are useless. Just initialize the fields directly. Don't recreate a new Date() for each of them: create it once. And note that Angular already have ways to get month and day names.
– JB Nizet
Nov 20 at 8:03
Ok thanks for your comment. Can you point me to "Angular's ways to get month and day names." ?
– Louis
Nov 20 at 22:57
angular.io/api/common/getLocaleMonthNames, angular.io/api/common/getLocaleDayNames, angular.io/guide/i18n
– JB Nizet
Nov 20 at 23:03
Well, it won't work, so I guess we can say it's not good practice. The view doesn't have access to local variables of the constructor. They're local variables.
– JB Nizet
Nov 20 at 6:52
Well, it won't work, so I guess we can say it's not good practice. The view doesn't have access to local variables of the constructor. They're local variables.
– JB Nizet
Nov 20 at 6:52
sorry I forgot a few lines and my code was not functional. My question is still there: is this best practices to put variables with
this.
in the constructor or should I put them elsewhere?– Louis
Nov 20 at 7:56
sorry I forgot a few lines and my code was not functional. My question is still there: is this best practices to put variables with
this.
in the constructor or should I put them elsewhere?– Louis
Nov 20 at 7:56
The monthNames and dayNames don't need to be recreated every time the constructor is invoked. Just store them in a constant, outside of the class. The other local variables are useless. Just initialize the fields directly. Don't recreate a new Date() for each of them: create it once. And note that Angular already have ways to get month and day names.
– JB Nizet
Nov 20 at 8:03
The monthNames and dayNames don't need to be recreated every time the constructor is invoked. Just store them in a constant, outside of the class. The other local variables are useless. Just initialize the fields directly. Don't recreate a new Date() for each of them: create it once. And note that Angular already have ways to get month and day names.
– JB Nizet
Nov 20 at 8:03
Ok thanks for your comment. Can you point me to "Angular's ways to get month and day names." ?
– Louis
Nov 20 at 22:57
Ok thanks for your comment. Can you point me to "Angular's ways to get month and day names." ?
– Louis
Nov 20 at 22:57
angular.io/api/common/getLocaleMonthNames, angular.io/api/common/getLocaleDayNames, angular.io/guide/i18n
– JB Nizet
Nov 20 at 23:03
angular.io/api/common/getLocaleMonthNames, angular.io/api/common/getLocaleDayNames, angular.io/guide/i18n
– JB Nizet
Nov 20 at 23:03
add a comment |
1 Answer
1
active
oldest
votes
up vote
0
down vote
It can't be considered as a practice in the first place as you can't do it. You can only access a Component's (public
) Properties and methods in your Component's Template.
You'll have to define a property on your Component for that.
...
@Component({...})
export class MemoryListPage implements OnInit {
...
thisMonth;
constructor(...) {
...
const thisMonth = monthNames[(new Date()).getMonth()];
this.thisMonth = thisMonth;
...
}
}
And then use it in your template:
<ion-label
no-margin
text-uppercase
color="white">
{{thisMonth}}
</ion-label>
UPDATE:
Answering your updated question, it's not really a good practice to write any instantiation logic in the constructor
. It should be written in ngOnInit
. Even the Angular's Official Docs vouch for this:
Experienced developers agree that components should be cheap and safe to construct.
Misko Hevery, Angular team lead, explains why you should avoid complex constructor logic.
add a comment |
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
It can't be considered as a practice in the first place as you can't do it. You can only access a Component's (public
) Properties and methods in your Component's Template.
You'll have to define a property on your Component for that.
...
@Component({...})
export class MemoryListPage implements OnInit {
...
thisMonth;
constructor(...) {
...
const thisMonth = monthNames[(new Date()).getMonth()];
this.thisMonth = thisMonth;
...
}
}
And then use it in your template:
<ion-label
no-margin
text-uppercase
color="white">
{{thisMonth}}
</ion-label>
UPDATE:
Answering your updated question, it's not really a good practice to write any instantiation logic in the constructor
. It should be written in ngOnInit
. Even the Angular's Official Docs vouch for this:
Experienced developers agree that components should be cheap and safe to construct.
Misko Hevery, Angular team lead, explains why you should avoid complex constructor logic.
add a comment |
up vote
0
down vote
It can't be considered as a practice in the first place as you can't do it. You can only access a Component's (public
) Properties and methods in your Component's Template.
You'll have to define a property on your Component for that.
...
@Component({...})
export class MemoryListPage implements OnInit {
...
thisMonth;
constructor(...) {
...
const thisMonth = monthNames[(new Date()).getMonth()];
this.thisMonth = thisMonth;
...
}
}
And then use it in your template:
<ion-label
no-margin
text-uppercase
color="white">
{{thisMonth}}
</ion-label>
UPDATE:
Answering your updated question, it's not really a good practice to write any instantiation logic in the constructor
. It should be written in ngOnInit
. Even the Angular's Official Docs vouch for this:
Experienced developers agree that components should be cheap and safe to construct.
Misko Hevery, Angular team lead, explains why you should avoid complex constructor logic.
add a comment |
up vote
0
down vote
up vote
0
down vote
It can't be considered as a practice in the first place as you can't do it. You can only access a Component's (public
) Properties and methods in your Component's Template.
You'll have to define a property on your Component for that.
...
@Component({...})
export class MemoryListPage implements OnInit {
...
thisMonth;
constructor(...) {
...
const thisMonth = monthNames[(new Date()).getMonth()];
this.thisMonth = thisMonth;
...
}
}
And then use it in your template:
<ion-label
no-margin
text-uppercase
color="white">
{{thisMonth}}
</ion-label>
UPDATE:
Answering your updated question, it's not really a good practice to write any instantiation logic in the constructor
. It should be written in ngOnInit
. Even the Angular's Official Docs vouch for this:
Experienced developers agree that components should be cheap and safe to construct.
Misko Hevery, Angular team lead, explains why you should avoid complex constructor logic.
It can't be considered as a practice in the first place as you can't do it. You can only access a Component's (public
) Properties and methods in your Component's Template.
You'll have to define a property on your Component for that.
...
@Component({...})
export class MemoryListPage implements OnInit {
...
thisMonth;
constructor(...) {
...
const thisMonth = monthNames[(new Date()).getMonth()];
this.thisMonth = thisMonth;
...
}
}
And then use it in your template:
<ion-label
no-margin
text-uppercase
color="white">
{{thisMonth}}
</ion-label>
UPDATE:
Answering your updated question, it's not really a good practice to write any instantiation logic in the constructor
. It should be written in ngOnInit
. Even the Angular's Official Docs vouch for this:
Experienced developers agree that components should be cheap and safe to construct.
Misko Hevery, Angular team lead, explains why you should avoid complex constructor logic.
answered Nov 20 at 8:07
SiddAjmera
12k21137
12k21137
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53387650%2fdisplay-const-in-template-with-angular-4-ionic%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Well, it won't work, so I guess we can say it's not good practice. The view doesn't have access to local variables of the constructor. They're local variables.
– JB Nizet
Nov 20 at 6:52
sorry I forgot a few lines and my code was not functional. My question is still there: is this best practices to put variables with
this.
in the constructor or should I put them elsewhere?– Louis
Nov 20 at 7:56
The monthNames and dayNames don't need to be recreated every time the constructor is invoked. Just store them in a constant, outside of the class. The other local variables are useless. Just initialize the fields directly. Don't recreate a new Date() for each of them: create it once. And note that Angular already have ways to get month and day names.
– JB Nizet
Nov 20 at 8:03
Ok thanks for your comment. Can you point me to "Angular's ways to get month and day names." ?
– Louis
Nov 20 at 22:57
angular.io/api/common/getLocaleMonthNames, angular.io/api/common/getLocaleDayNames, angular.io/guide/i18n
– JB Nizet
Nov 20 at 23:03